search

drozhzhin-n-e / ngx-pinch-zoom

Module provides for image zooming and positioning with use of gestures on a touch screen.
http://ivylab.space/pinch-zoom
MIT License
113 stars 95 forks source link

Angular 12 #88

Open ramoncarreras opened 3 years ago

ramoncarreras commented 3 years ago

Would it be possible to bump angular to version 12?

AE1NS commented 3 years ago

@drozhzhin-n-e is this repository still active and will be updated to Angular 12?

marshall86 commented 3 years ago

interesting to have this update as well please

z-index-developer commented 3 years ago

I'm interested in this update too.

cool-itkfm commented 3 years ago

I would also really need this update

muuvmuuv commented 3 years ago

It works fine here on ng12 and 13. What exactly is the problem?

marshall86 commented 3 years ago

if there is no issue, we just need the package.json to be updated to the latest angular version pls

mejriyassine commented 2 years ago

i managed to install it with --force on angular 12 and works fine

chrisvelevitch commented 2 years ago

When using with Angular 13, npm gives the following warnings:-

npm WARN ngx-pinch-zoom@2.6.2 requires a peer of @angular/common@^11.1.2 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-pinch-zoom@2.6.2 requires a peer of @angular/core@^11.1.2 but none is installed. You must install peer dependencies yourself.
danielehrhardt commented 2 years ago

When using with Angular 13, npm gives the following warnings:-

npm WARN ngx-pinch-zoom@2.6.2 requires a peer of @angular/common@^11.1.2 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-pinch-zoom@2.6.2 requires a peer of @angular/core@^11.1.2 but none is installed. You must install peer dependencies yourself.

https://github.com/across-the-stars/ngx-pinch-zoom/commit/b888a61ff1be0c0855b644c8283bebf51940ec6f Someone updated to Angular 12. https://github.com/across-the-stars/ngx-pinch-zoom

muuvmuuv commented 2 years ago

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

danielehrhardt commented 2 years ago

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

same.

aceleghin commented 2 years ago

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

Same

HusFNS commented 2 years ago

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

how did you solve this?

muuvmuuv commented 2 years ago

Deinstall and use instructions to STRG+/- 😅 ... we are using a JS Vanilla lib instead