search

drud / quicksprint

A basic toolkit to get people started with ddev and a Drupal codebase on macOS, Linux, or WIndows
Other
24 stars 16 forks source link

Clarifies sprint user docs that confused users #96

Closed mradcliffe closed 5 years ago

mradcliffe commented 5 years ago

Making review changes from #95.

rfay commented 5 years ago

Thanks for stepping back in there @mradcliffe ! One of our priorities this year is to have everything buttoned down before Drupalcon with some time for burning flash drives.

rfay commented 5 years ago

Looks like the testing on Windows will need some love.

mradcliffe commented 5 years ago

Thanks. Yes, I'm putting more time back into this with Brian soonish.

mradcliffe commented 5 years ago

I can't remember. Does the buildkite configuration run both the package build and the install or only take the artifacts from circleci and run the installer and sprint tools?

rfay commented 5 years ago

Builds and installs - you can look at https://github.com/drud/quicksprint/blob/master/.buildkite/test.sh - I'll try to fix it later this week. We have a release tomorrow so will be attending to that first.

mradcliffe commented 5 years ago

I tried running package_drupal_script.sh, but I didn't have jq (easily obtained) so it failed immediately. Not sure if that's the issue on buildkite.

mradcliffe commented 5 years ago

Packager fails because zip isn't available (git for windows does not package that).

Was buildkite's thing ever working or maybe it was silently failing?

rfay commented 5 years ago

Windows successful now (after retries). Not sure what was wrong, but we'll keep an eye on it and if it's a particular testbot, we'll be able to solve it. I reorganized the required checks and retried the circleci build.

mradcliffe commented 5 years ago

Yes, that's correct. Since I opened it, you can merge.