Loose generation fails for nested schema

[xronos-i-am]

Describe the bug

In "loose" mode JSON schema should be generated. The following code throws Dry::Schema::JSONSchema::SchemaCompiler::UnknownConversionError instead

To Reproduce

require 'bundler/inline'

gemfile do
  gem "dry-schema"
end

require "dry-schema"

Dry::Schema.load_extensions(:json_schema)

schema = Dry::Schema.Params do
  required(:personal_info).filled(:hash) do
    required(:email).filled(:string, format?: /@/)
  end
end

schema.json_schema(loose: true)

Expected behavior

A valid JSON schema

My environment

• Affects my production application: YES
• Ruby version: 2.7
• OS: ubuntu

[solnic]

What if you do:

schema = Dry::Schema.Params do
  required(:personal_info).hash do
    required(:email).filled(:string, format?: /@/)
  end
end

??

[xronos-i-am]

schema = Dry::Schema.Params do
  required(:personal_info).hash do
    required(:email).filled(:string, format?: /@/)
  end
end

Nothing changed, same error

[solnic]

What if you remove the format? part?

[xronos-i-am]

What if you remove the format? part?

It works

{:$schema=>"http://json-schema.org/draft-06/schema#",
 :type=>"object",
 :properties=>
  {:personal_info=>
    {:type=>"object",
     :properties=>{:email=>{:type=>"string", :minLength=>1}},
     :required=>["email"]}},
 :required=>["personal_info"]}

[solnic]

Yeah so it's just that there's no support for format? predicate yet.

[xronos-i-am]

not quite, the following works too:

schema = Dry::Schema.Params do
  required(:email).filled(:string, format?: /@/)
end

{:$schema=>"http://json-schema.org/draft-06/schema#",
 :type=>"object",
 :properties=>{:email=>{:type=>"string", :minLength=>1}},
 :required=>["email"]}

[xronos-i-am]

so, the problem is nesting

[xronos-i-am]

sorry, fixed in https://github.com/dry-rb/dry-schema/commit/35bf48e96f47158f54f19156952835f957ef6f7e