dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
345 stars 142 forks source link

ADKDSKey: Fixes #648, the resource did not work due to a non-working date conversion #649

Closed raandree closed 2 years ago

raandree commented 3 years ago

Pull Request (PR) description

The resource did not work due to a non-working date conversion as described in #648.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #649 (bfddebb) into main (04f5f39) will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #649   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3408           
===================================
  Hits       3340   3340           
  Misses       68     68           
Impacted Files Coverage Δ
...urce/DSCResources/MSFT_ADKDSKey/MSFT_ADKDSKey.psm1 100% <100%> (ø)
johlju commented 2 years ago

Let us merge this based on the https://github.com/dsccommunity/ActiveDirectoryDsc/issues/648#issuecomment-850886442.