dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
345 stars 142 forks source link

ADGroup: add SamAccountName parameter #658

Open gaelicWizard opened 3 years ago

gaelicWizard commented 3 years ago

Pull Request (PR) description

Adds optional parameter SamAccountName to ADGroup resource to allow setting this property separately. This requires that GroupName be specified using something other than the SamAccountName, e.g. SID, DN, UPN, &c.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #658 (11a3dd5) into main (9346a1d) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #658   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3412    +4     
===================================
+ Hits       3340   3344    +4     
  Misses       68     68           
X-Guardian commented 3 years ago

PR #651 must be merged before this PR and it will then need refactoring.