dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
345 stars 142 forks source link

Fix ad domain controller #686

Closed jkattmann closed 2 years ago

jkattmann commented 2 years ago

Pull Request (PR) description

Created Get-DomainObject in ActiveDirectoryDsc.Common to wrap Get-ADDomain calls with common retry logic and refactor ADDomainController & ADDomain to utilize it.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #686 (94e0b5a) into main (b8c9012) will decrease coverage by 0%. The diff coverage is 96%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #686   +/-   ##
===================================
- Coverage    98%    97%   -1%     
===================================
  Files        25     25           
  Lines      3420   3433   +13     
===================================
+ Hits       3352   3364   +12     
- Misses       68     69    +1     
Impacted Files Coverage Δ
...DirectoryDsc.Common/ActiveDirectoryDsc.Common.psm1 95% <96%> (+<1%) :arrow_up:
...urce/DSCResources/MSFT_ADDomain/MSFT_ADDomain.psm1 100% <100%> (ø)
...FT_ADDomainController/MSFT_ADDomainController.psm1 100% <100%> (ø)