dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
341 stars 141 forks source link

ADReplicationSiteLink: Fix for Options when ReplicationFrequencyInMinute not set #699

Closed Borgquite closed 1 year ago

Borgquite commented 1 year ago

Pull Request (PR) description

Allow OptionChangeNotification, OptionTwoWaySync and OptionDisableCompression to be updated even if ReplicationFrequencyInMinutes is not set (fixes #637)

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

johlju commented 1 year ago

/azurepipelines run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
codecov[bot] commented 1 year ago

Codecov Report

Merging #699 (413817e) into main (b2838d9) will not change coverage. Report is 1 commits behind head on main. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #699   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3471   3471           
===================================
  Hits       3402   3402           
  Misses       69     69           
Files Changed Coverage Δ
...eplicationSiteLink/MSFT_ADReplicationSiteLink.psm1 99% <100%> (ø)