ADSRootKey: Resolved 'String was not recognized as a valid DateTime' in non-US cultures

[Borgquite]

Pull Request (PR) description

Fix #702 where 'String was not recognised as a valid DateTime' can occur with non en-US cultures

This Pull Request (PR) fixes the following issues

• Fixes #702

Task list

• [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [ ] Resource documentation added/updated in README.md.
• [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
• [ ] Comment-based help added/updated.
• [ ] Localization strings added/updated in all localization files as appropriate.
• [ ] Examples appropriately added/updated.
• [ ] Unit tests added/updated. See DSC Community Testing Guidelines.
• [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• [x] New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[johlju]

I fixed the test pipeline, it failed on an unrelated error. I seems a recent update to PS 7.4.1 on the build worker was not compatible with the unit tests. If you pull in changes from main the tests should not fail, at least not on that unrelated error. 🙂

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (131fb75) 98% compared to head (1f0feb9) 98%. Report is 2 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/703?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #703 +/- ## =================================== Coverage 98% 98% =================================== Files 25 25 Lines 3471 3471 =================================== Hits 3402 3402 Misses 69 69 ``` | [Files](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/703?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...urce/DSCResources/MSFT\_ADKDSKey/MSFT\_ADKDSKey.psm1](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/703?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9NU0ZUX0FES0RTS2V5L01TRlRfQURLRFNLZXkucHNtMQ==) | `100% <100%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/703/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)

[Borgquite]

@johlju Ah, thank you. I saw the test error but couldn't work out for the life of me how my simple tweak was breaking the test - amazing coincidence that the issues was also in the ADSRootKey test! :D

[johlju]

@Borgquite thanks for this! It will release in a preview shortly, let me know that it works and I make a full release.

[Borgquite]

@johlju All looks good from here - good to release :)