dsccommunity / FailoverClusterDsc

This module contains DSC resources for deployment and configuration of Windows Server Failover Cluster.

MIT License

60 stars 54 forks source link

xFailOverCluster: Opt-in for module files common tests #120

Closed johlju closed 7 years ago

johlju commented 7 years ago

Pull Request (PR) description

Changes to xFailOverCluster
- Opt-in for module files common tests (issue #119).
- Removed Byte Order Mark (BOM) from the files; CommonResourceHelper.psm1 and FailoverClusters.stubs.psm1.

This Pull Request (PR) fixes the following issues: Fixes #119

Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and (optional) Integration tests created/updated where possible?

This change is

msftclas commented 7 years ago

@johlju, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request. Thanks, Microsoft Pull Request Bot

codecov-io commented 7 years ago

Codecov Report

Merging #120 into dev will not change coverage. The diff coverage is n/a.

@@        Coverage Diff         @@
##           dev   #120   +/-   ##
==================================
  Coverage   90%    90%           
==================================
  Files        7      7           
  Lines      379    379           
==================================
  Hits       343    343           
  Misses      36     36

johlju commented 7 years ago

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

johlju commented 7 years ago

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable