dsccommunity / FailoverClusterDsc

This module contains DSC resources for deployment and configuration of Windows Server Failover Cluster.
MIT License
60 stars 54 forks source link

xFailoverCluster: Removed Byte Order Mark (BOM) from script file #130

Closed johlju closed 7 years ago

johlju commented 7 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues: For some reason the tests did not fail on this in the PR. But failed after merge, when the dev branch was tested. :/

Task list:


This change is Reviewable

msftclas commented 7 years ago

@johlju, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request. Thanks, Microsoft Pull Request Bot

johlju commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

johlju commented 7 years ago
:lgtm:

Merging this as soon as the test passes. So the Dev branch passes the tests.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

codecov-io commented 7 years ago

Codecov Report

Merging #130 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #130   +/-   ##
==================================
  Coverage   99%    99%           
==================================
  Files        7      7           
  Lines      381    381           
==================================
  Hits       379    379           
  Misses       2      2