dsccommunity / FailoverClusterDsc

This module contains DSC resources for deployment and configuration of Windows Server Failover Cluster.
MIT License
60 stars 54 forks source link

xClusterQuorum: Add Cloud Witness to WSFC in W2016 #160

Closed jmos5156 closed 6 years ago

jmos5156 commented 6 years ago

Adding the ability to pass Azure storage account details to create a cloud witness during the creation of a WSFC

Pull Request (PR) description Adding the ability to pass Azure storage account details to create a cloud witness during the creation of a WSFC

This Pull Request (PR) fixes the following issues:

Task list:


This change is Reviewable

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

codecov-io commented 6 years ago

Codecov Report

Merging #160 into dev will decrease coverage by <1%. The diff coverage is 92%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #160   +/-   ##
===================================
- Coverage   100%    99%   -1%     
===================================
  Files         7      7           
  Lines       413    408    -5     
===================================
- Hits        413    406    -7     
- Misses        0      2    +2
johlju commented 6 years ago

@jmos5156 First, thanks for sending in these changes. It seems that you have not updated your branch with the latest changes? Your PR will remove a lot of changes, for example comment-based help. Can you please do git rebase (do not use git pull or git merge) on your branch against the dev branch. Please see here how to do that; https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts

johlju commented 6 years ago

@jmos5156 These changes has already been suggested in PR #153. Does this change build on top of that PR?

johlju commented 6 years ago

Closing this PR since cloud witness functionality has just been merged in PR #153. If this PR adds more functionality, then please reopen this PR and submit new commits or please resubmit a new PR.