dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 227 forks source link

`Install-SqlDscServer`: Fix `ASSysAdminAccounts` and `SqlSysAdminAccounts` #1863

Closed johlju closed 1 year ago

johlju commented 1 year ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #1863 (d8b4465) into main (58b765c) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1863   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        85      85           
  Lines      7607    7614    +7     
====================================
+ Hits       7005    7012    +7     
  Misses      602     602           
Flag Coverage Δ
unit 92% <100%> (+<1%) :arrow_up:
Impacted Files Coverage Δ
source/Private/Invoke-SetupAction.ps1 92% <ø> (ø)
source/Public/Install-SqlDscServer.ps1 100% <ø> (ø)
source/Private/Assert-SetupActionProperties.ps1 98% <100%> (+<1%) :arrow_up: