dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 227 forks source link

SqlWindowsFirewall: Avoid Duplication of SQL Server Browser Firewall Rule #1944

Closed jerfried closed 1 year ago

jerfried commented 1 year ago

Pull Request (PR) description

This change avoids duplicating the Browser Firewall Rule for the AS feature which leads to an error in in subsequent Test-TargetResource runs.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #1944 (64e8c2e) into main (f9bde8a) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1944   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        92      92           
  Lines      7808    7810    +2     
====================================
+ Hits       7183    7185    +2     
  Misses      625     625           
Flag Coverage Δ
unit 91% <100%> (+<1%) :arrow_up:
Impacted Files Coverage Δ
...DSC_SqlWindowsFirewall/DSC_SqlWindowsFirewall.psm1 100% <100%> (ø)
johlju commented 1 year ago

Thanks for this fix! 🙇‍♂️

jerfried commented 1 year ago

Great pleasure, thanks for reviewing and suggesting it :)