dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.
https://dsccommunity.org
MIT License
66 stars 51 forks source link

Add SerialNumber as a disk identifier to Disk, DiskAccessPath and Wai… #271

Closed dshelb closed 1 year ago

dshelb commented 1 year ago

Pull Request (PR) description:

This PR introduces support for using disk serial number as a disk identifier in disk-related resources Disk, DiskAccessPath and WaitForDisk.

This Pull Request (PR) fixes the following issues: Fixes https://github.com/dsccommunity/StorageDsc/issues/259

Task list:


This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #271 (64344d9) into main (b4f8a2a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #271   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines       882    882           
===================================
  Hits        842    842           
  Misses       40     40           
Impacted Files Coverage Δ
source/DSCResources/DSC_Disk/DSC_Disk.psm1 98% <ø> (ø)
...sources/DSC_DiskAccessPath/DSC_DiskAccessPath.psm1 89% <ø> (ø)
.../DSCResources/DSC_WaitForDisk/DSC_WaitForDisk.psm1 100% <ø> (ø)
...e/Modules/StorageDsc.Common/StorageDsc.Common.psm1 100% <ø> (ø)
dshelb commented 1 year ago

Let's flag this for now and skip the integration tests for SerialNumber as the Disk Identifier.