Trigger BREAKING CHANGE major release - Fixes #282

PlagueHO commented 10 months ago

@johlju - this is a BREAKING CHANGE commit. I'm going to squash merge this into a new commit anyway (with BREAKING CHANGE) to trigger the major version bump.

Pull Request (PR) description

Administrative PR to force major version bump.,

This Pull Request (PR) fixes the following issues

Fixes @282

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[x] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[ ] New/changed code adheres to DSC Community Style Guidelines.

@johlju - would you mind reviewing when you have time?

This change is

johlju commented 10 months ago

Not sure why the review message says it’s waiting for you @PlagueHO. All files looks good to me and can’t see I missed any. Very strange.

Good to squash merge.

codecov[bot] commented 10 months ago

Codecov Report

Merging #283 (a9c3a7d) into main (6473a60) will not change coverage. The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #283   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines      1025   1025           
===================================
  Hits        977    977           
  Misses       48     48

johlju commented 10 months ago

Btw the commit message “bump major version” suffice as commit message too. It looks for these keywords:

https://github.com/dsccommunity/StorageDsc/blob/6473a60680135b3f577230af1da8316bca0f497c/GitVersion.yml#L3

PlagueHO commented 10 months ago

Thanks @johlju - hopefully will work now. I'll get you to remove the old preview package once the new 6 preview is published.

johlju commented 10 months ago

Since v6 was released I have unlisted the 5.2.0-preview1 version. It won’t show up in search results any longer.

dsccommunity / StorageDsc