Closed PlagueHO closed 10 months ago
Not sure why the review message says it’s waiting for you @PlagueHO. All files looks good to me and can’t see I missed any. Very strange.
Good to squash merge.
Merging #283 (a9c3a7d) into main (6473a60) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #283 +/- ##
===================================
Coverage 95% 95%
===================================
Files 7 7
Lines 1025 1025
===================================
Hits 977 977
Misses 48 48
Btw the commit message “bump major version” suffice as commit message too. It looks for these keywords:
Thanks @johlju - hopefully will work now. I'll get you to remove the old preview package once the new 6 preview is published.
Since v6 was released I have unlisted the 5.2.0-preview1 version. It won’t show up in search results any longer.
@johlju - this is a BREAKING CHANGE commit. I'm going to squash merge this into a new commit anyway (with BREAKING CHANGE) to trigger the major version bump.
Pull Request (PR) description
Administrative PR to force major version bump.,
This Pull Request (PR) fixes the following issues
Task list
@johlju - would you mind reviewing when you have time?
This change is![Reviewable](https://reviewable.io/review_button.svg)