dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
35 stars 47 forks source link

xRDServer: key expanded to include role property #66

Closed NReilingh closed 4 years ago

NReilingh commented 4 years ago

Pull Request (PR) description

When Server is the only key, it is impossible to configure more than one role on a server.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov-io commented 4 years ago

Codecov Report

Merging #66 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #66   +/-   ##
=====================================
  Coverage   87.4%   87.4%           
=====================================
  Files          8       8           
  Lines        381     381           
  Branches       9       9           
=====================================
  Hits         333     333           
  Misses        39      39           
  Partials       9       9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74ab3ee...35505aa. Read the comment docs.

danielboth commented 4 years ago

@gaelcolas, can we get some help merging this?

gaelcolas commented 4 years ago

@danielboth I assume you can do now, let me know if any issue.

danielboth commented 4 years ago

Thanks @gaelcolas and thanks @NReilingh for this contribution!