dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
35 stars 47 forks source link

xRDCertificateConfiguration: New resource to enable certificate management #67

Closed danielboth closed 4 years ago

danielboth commented 4 years ago

Pull Request (PR) description

New resource to enable the management of the certificates in a remote desktop deployment. This resource enables the configuration of each role individually, so users can have different certificates between roles.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov-io commented 4 years ago

Codecov Report

Merging #67 into dev will increase coverage by 0.65%. The diff coverage is 93.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev      #67      +/-   ##
=========================================
+ Coverage   87.4%   88.05%   +0.65%     
=========================================
  Files          8        9       +1     
  Lines        381      427      +46     
  Branches       9       10       +1     
=========================================
+ Hits         333      376      +43     
- Misses        39       41       +2     
- Partials       9       10       +1
Impacted Files Coverage Δ
xRemoteDesktopSessionHostCommon.psm1 86.66% <84.61%> (-13.34%) :arrow_down:
...onfiguration/MSFT_xRDCertificateConfiguration.psm1 97.22% <97.22%> (ø)
...RDSessionDeployment/MSFT_xRDSessionDeployment.psm1 94.73% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 213f798...e746158. Read the comment docs.

danielboth commented 4 years ago

Hi @johlju, would you have some time to review?

danielboth commented 4 years ago

This PR was moved to: https://github.com/dsccommunity/xRemoteDesktopSessionHost/pull/75