dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
36 stars 47 forks source link

xRDRemoteApp strip common parameters in Test-TargetResource #70

Closed danielboth closed 4 years ago

danielboth commented 4 years ago

Pull Request (PR) description

This PR fixes an issue where (for example) Verbose is passed to Test-TargetResource in xRDRemoteApp, which will then be compared vs the current configuration.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #70 into master will increase coverage by 0.06%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage    87.4%   87.46%   +0.06%     
==========================================
  Files           8        8              
  Lines         381      383       +2     
  Branches        9        9              
==========================================
+ Hits          333      335       +2     
  Misses         39       39              
  Partials        9        9
Impacted Files Coverage Δ
...Resources/MSFT_xRDRemoteApp/MSFT_xRDRemoteApp.psm1 97.87% <100%> (+0.09%) :arrow_up:
...RDSessionDeployment/MSFT_xRDSessionDeployment.psm1 94.73% <83.33%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 581908b...371736d. Read the comment docs.