search

dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
35 stars 47 forks source link

xRDSessionCollectionConfiguration: Various Parameters are not properly compared #82

Closed jeremyciak closed 3 years ago

jeremyciak commented 4 years ago

Details of the scenario you tried and the problem that is occurring

Supplying values for certain parameters either does not function as intended, or sometimes even throws errors. Parameters impacted:

Verbose logs showing the problem

Suggested solution to the issue

Perform some normalization against the provided parameters and current values to do a proper comparison

The DSC configuration that is used to reproduce the issue (as detailed as possible)

xRDSessionCollectionConfiguration 'TestSessionCollection'
{
    CollectionName        = 'TestSessionCollection'
    EnableUserProfileDisk = $true
    DiskPath              = 'C:\temp'
    ExcludeFilePath       = @()
    ExcludeFolderPath     = @('C:\temp\foo', 'C:\temp\bar')
    IncludeFilePath       = @()
    IncludeFolderPath     = @()
}

The operating system the target node is running

OsName               : Microsoft Windows Server 2019 Datacenter
OsOperatingSystemSKU : DatacenterServerEdition
OsArchitecture       : 64-bit
WindowsVersion       : 1809
WindowsBuildLabEx    : 17763.1.amd64fre.rs5_release.180914-1434
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

Version and build of PowerShell the target node is running

Name                           Value                                                                                                                                                                                                
----                           -----                                                                                                                                                                                                
PSVersion                      5.1.17763.1007                                                                                                                                                                                       
PSEdition                      Desktop                                                                                                                                                                                              
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                                                                                                              
BuildVersion                   10.0.17763.1007                                                                                                                                                                                      
CLRVersion                     4.0.30319.42000                                                                                                                                                                                      
WSManStackVersion              3.0                                                                                                                                                                                                  
PSRemotingProtocolVersion      2.3                                                                                                                                                                                                  
SerializationVersion           1.1.0.1

Version of the DSC module that was used

2.0.0-preview0003

jeremyciak commented 4 years ago

PR for proposed solution: #83

jeremyciak commented 4 years ago

@johlju or any other contributors... Any thoughts?

johlju commented 4 years ago

@ ld0614 do you have time to look at this and the PR proposal?

jeremyciak commented 4 years ago

I think you put separation between your '@' and the username. Here is another attempt: @ld0614

danielboth commented 3 years ago

This was fixed in #83