search

dstansby / pfsspy

Potential Field Source Surface model package for Python
https://pfsspy.readthedocs.io/
Other
40 stars 17 forks source link

Examples using multiple SFT simulation output #335

Closed mfcorchado closed 2 years ago

mfcorchado commented 2 years ago

Two python scripts that show the evolution of the PFSS solution as a Surface Flux Transport model simulates the 11 year solar-like cycle, see the following issue.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 0cd13c94cec13fac3cd3a676a509e1919275bb07 into f1fecd092227ffd32ac7b15aa53c96941190e114 - view on LGTM.com

new alerts:

dstansby commented 2 years ago

Thanks again for opening this. As it stands I don't think this is mergeable because it the examples aren't self contained, ie. you need external data to run them, which means we can't generate the example output when automatically building the documentation. If you can modify the example to fix this feel free to open an new PR, or comment here and I can re-open this one.

mfcorchado commented 2 years ago

Hi David,

Thank you for the input on this issue. It was definitely meant more as learning experiences as part of a coding class but I will try to make it more self contained, and see if it can add new feature than already existing in the other example tools. Thanks again for the feedback and suggestions.

Cheers, Marcel

On Fri, Jan 14, 2022 at 5:12 AM David Stansby @.***> wrote:

Thanks again for opening this. As it stands I don't think this is mergeable because it the examples aren't self contained, ie. you need external data to run them, which means we can't generate the example output when automatically building the documentation. If you can modify the example to fix this feel free to open an new PR, or comment here and I can re-open this one.

— Reply to this email directly, view it on GitHub https://github.com/dstansby/pfsspy/pull/335#issuecomment-1013066811, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVLFKTT7V6SQZLZWHHHITZ3UWAHKTANCNFSM5JMLKYOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>