search

dtcooper / python-fitparse

Python library to parse ANT/Garmin .FIT files
http://pythonhosted.org/fitparse/
MIT License
738 stars 184 forks source link

check whether message actually contains units. if not, set units to None #109

Closed gschramm closed 4 years ago

gschramm commented 4 years ago

Fixes #107

The output of the test scripts after my change was: (base) georg@amun:~/Desktop/python-fitparse/tests$ python test.py .....................

Ran 21 tests in 29.247s

OK (base) georg@amun:~/Desktop/python-fitparse/tests$ python test_records.py ..

Ran 2 tests in 0.000s

OK (base) georg@amun:~/Desktop/python-fitparse/tests$ python test_utils.py ...

Ran 3 tests in 0.001s

pR0Ps commented 4 years ago

@gschramm Thanks for your help - I ended up fixing it in a more general way since there were a bunch of other fields that could've had the same issue.

gschramm commented 4 years ago

@pR0Ps Thanks for fixing it! Are you planning a new release soon that people can install from pypi?

pR0Ps commented 4 years ago

@gschramm For sure, I just want to fix a few other small things first.