search

dteviot / WebToEpub

A simple Chrome (and Firefox) Extension that converts Web Novels (and other web pages) into an EPUB.
Other
735 stars 139 forks source link

ToDo: Base implementation of extractDescription() in class Parser should use informationEpubItem #1484

Closed dteviot closed 2 months ago

dteviot commented 2 months ago

The description and information page both have story synopsis. Rather than duplicate the functionality/code, the base implementation of extractDescription() should use the results of getInformationEpubItem().

Because far more parsers implement getInformationEpubItem() than extractDescription()

dteviot commented 2 months ago

On further examination, might not be such a good idea. Some parsers are sloppy and don't just pull in the synopsis, but more details.

On the third hand, if that's a problem, can aways override extractDescription() in the offending parsers.

dteviot commented 2 months ago

Notes Time taken: 42 minutes