dteviot / WebToEpub

A simple Chrome (and Firefox) Extension that converts Web Novels (and other web pages) into an EPUB.
Other
735 stars 139 forks source link

Add option to skip 403 retries, for content that is legitimately not available #1491

Closed fake-name closed 1 month ago

fake-name commented 2 months ago

Basically, I have a number of stories where LARGE swathes content has gone inaccessible. For example, there are a number of series where the author has (rather foolishly) used direct links to their patreon-hosted images in a publicly available story.

Downloading these is extremely annoying, because you get a "you might need to log in to a site" prompt for EVERY ONE of the broken links. You can wind up literally having to click "Yes, I know" more then a hundred times for a single series.

This is extremely annoying.

It seems to me, given there is already a facility for deciding whether to ask the user (wrapOptions.retry.promptUser), that an option that just globally forces that to false would be very nice from a user standpoint.

fake-name commented 2 months ago

For the moment, I've kind of "redneck patched" the issue by just removing all alert() calls in getAutomaticRetryBehaviourForStatus(), and changing all promptUser values to false, but that's not a general fix. Ideally this would be something exposed through the UI, but I'm not smart enough to make that set of changes myself.

fake-name commented 2 months ago

As an aside, I think that https://github.com/dteviot/WebToEpub/pull/1420 causes a JS alert() dialog box, that if you cancel it, you then get webtoepub's "do you want to handle this" display, which you then again have to cancel. I think that's probably not intended?

gamebeaker commented 2 months ago

@fake-name do you have an example story with problematic content?

fake-name commented 2 months ago

Try https://www.scribblehub.com/series/945582/the-heavenly-martial-empress-returns-an-op-xianxia-returnee-litrpg/

gamebeaker commented 2 months ago

https://www.scribblehub.com/series/945582/the-heavenly-martial-empress-returns-an-op-xianxia-returnee-litrpg/ Chapter 36 is problematic.

gamebeaker commented 2 months ago

The current flowchart for HTTP 403: Neues draw io Diagramm-93867 drawio

gamebeaker commented 2 months ago

@fake-name I changed how 403 gets handled is the new solution ok? Test versions for Firefox and Chrome have been uploaded to https://github.com/dteviot/WebToEpub/releases/tag/developer-build. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes. Tested with:

dteviot commented 1 month ago

@fake-name Updated version (1.0.0.0) has been submitted to Firefox and Chrome stores. Firefox version is available now. Chrome might be available in a few hours to 21 days.