dteviot / WebToEpub

A simple Chrome (and Firefox) Extension that converts Web Novels (and other web pages) into an EPUB.
Other
735 stars 139 forks source link

Create convertTableToDiv to fix royalroad tables on tolino #1516

Closed gamebeaker closed 1 month ago

gamebeaker commented 1 month ago

reference: #1455 To use the change add this to the Stylesheet:

.WebToEpub-table {
    border-collapse: collapse;
    width: 100%;
}
.WebToEpub-row {
    display: flex;
    border: 1px solid black;
}
.WebToEpub-cell {
    flex: 1;
    padding: 5px;
    border: 1px solid black;
}

@dteviot as this is really obscure i would appreciate other ideas to enable this option. Maybe a new Checkbox "tolino compatibility"?. Why not always convert tables to div? It looks like only tolino has the problem and not other reader. As the table looks better than the div version other user shouldn't be impacted from the tolino fix.

Tested with: https://www.royalroad.com/fiction/22546/inexorable-chaos-complete/chapter/324087/chapter-four-abnormal-summoning There is a table in a table and the table is to long for tolino.

gamebeaker commented 1 month ago

@dteviot

@gamebeaker I'm going to say, this isn't something for WebToEpub to do. Instead, should provide a script in EpubEditor. Originally posted by @dteviot in https://github.com/dteviot/WebToEpub/issues/1455#issuecomment-2377793706

Can i leave it in WebToEpub as a "hidden" feature? .WebToEpub-table needs to be in the Stylesheet or it is skipped. Or should i revert the commit?

dteviot commented 1 month ago

@gamebeaker Have to go to work. Will get back to you.