search

dthiendoan / liche-bot

Based on hubot for hipchat
5 stars 4 forks source link

[feature] added haiku command to print out three random gossip lines. #3

Open david-zou opened 7 years ago

david-zou commented 7 years ago

[6/27/2017] Changes Made:

  1. Improved code styling based on suggestions in PR.
  2. Revised haiku code in findGossip() to better reflect issue specifications.

Impact or Risks: Because some of the code is hard coded, it might incur technical debt if further changes were to be made to the findGossip() function in the future.

Testing: This code was manually tested via private Slack channel using niconico-bot. Several cases were tested -

  1. Tested case for zero entries in database
  2. Tested case for one entry in database
  3. Tested case for two entries in database
  4. Tested case for at least three entries in database
  5. Tested all other commands to ensure that they are still working

Fallback Procedure: Revert to previous working commit.

References: https://github.com/Liche/liche-bot/issues/1

Ryxias commented 7 years ago

Another piece of feedback: Please fill out your PR description with useful information. Good guidelines to follow:

1) Summary of what the changes are 2) Impact or risks 3) Summary of how you tested it or how you plan on testing it 4) Summary on how you will revert if things go badly 5) Link to relevant design doc(s) or GH Issues