duartegroup / autodE

automated reaction profile generation
https://duartegroup.github.io/autodE/
MIT License
165 stars 51 forks source link

Added conformer Boltzmann weighting function #256

Closed aleksy-k closed 1 year ago

aleksy-k commented 1 year ago

Added Boltzmann prune. Keeps conformers up to threshold, including the final conformers that takes the cumulative threshold over the threshold.

Checklist

t-young31 commented 1 year ago

oh alsotemperature -> temp for naming consistency with the rest of the code (wish it was temperature, but feels like we're stuck now!)

aleksy-k commented 1 year ago

All comments look good (but please see the one RE self.sort() ) - will rebase to v1.4.0

codecov[bot] commented 1 year ago

Codecov Report

Merging #256 (fc24d58) into v1.4.0 (db4df39) will increase coverage by 5.60%. The diff coverage is 15.62%.

@@            Coverage Diff             @@
##           v1.4.0     #256      +/-   ##
==========================================
+ Coverage   91.61%   97.21%   +5.60%     
==========================================
  Files         195      195              
  Lines       20403    20435      +32     
==========================================
+ Hits        18692    19866    +1174     
+ Misses       1711      569    -1142     
Flag Coverage Δ
unittests 97.21% <15.62%> (+5.60%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
autode/conformers/conformers.py 80.88% <7.14%> (-16.34%) :arrow_down:
autode/conformers/conformer.py 98.63% <75.00%> (-1.37%) :arrow_down:
autode/wrappers/keywords/keywords.py 99.67% <0.00%> (+0.32%) :arrow_up:
autode/calculations/calculation.py 99.31% <0.00%> (+0.68%) :arrow_up:
autode/wrappers/methods.py 95.00% <0.00%> (+0.83%) :arrow_up:
autode/path/path.py 98.85% <0.00%> (+1.14%) :arrow_up:
tests/test_species.py 100.00% <0.00%> (+1.21%) :arrow_up:
autode/values.py 100.00% <0.00%> (+1.39%) :arrow_up:
autode/opt/coordinates/base.py 100.00% <0.00%> (+1.62%) :arrow_up:
autode/transition_states/templates.py 93.85% <0.00%> (+1.67%) :arrow_up:
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

t-young31 commented 1 year ago

basically just needs some tests now – lovely jubbly

aleksy-k commented 1 year ago

Might need to assert energy is not None?

t-young31 commented 1 year ago

will need a new PR against the v1.4.1 branch