dubinc / dub

Open-source link management infrastructure. Loved by modern marketing teams like Vercel, Raycast, and Perplexity.
https://dub.co
GNU Affero General Public License v3.0
19k stars 2.06k forks source link

UI Issue on UTM Drawer when user clicks cancel on Mobile #1624

Open FaheemOnHub opened 1 month ago

FaheemOnHub commented 1 month ago

Issue Summary When accessing on Mobile, after the user click create link and adds the details, incase the user clicks on UTM Button and cancels, the whole create link operation gets cancelled.This issue causes problem for the user while creating link.

Steps to Reproduce

  1. Open the app on mobile device
  2. Click create link and add details
  3. Click on UTM and press cancel
  4. It will throw the user to main whereas it should go back to create link page where the added details should be present.

Expected behavior

In case the user pressed cancel inside the UTM, the app should go back to the create-link page where the user has already added details of the link.

kindly assign this issue to me

Screenshots/Videos

https://github.com/user-attachments/assets/b6a23f0e-2558-4dc7-b0f4-4e983265ae20

Version info Tested on both:

iPhone 15 iOS 17 Edge Version 130.0.2849.46 (Official build) (arm64)

linear[bot] commented 1 month ago

ENG-871 UI Issue on UTM Drawer when user clicks cancel on Mobile

oss-gg[bot] commented 1 month ago

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

steven-tey commented 1 month ago

/award 150 thanks for the bug report!

oss-gg[bot] commented 1 month ago

Awarding FaheemOnHub: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/FaheemOnHub

Hustler-Sameer commented 1 week ago

@steven-tey Hey , if you have any new good first issues , please let me know

unrenamed commented 1 week ago

@Hustler-Sameer I believe I might have identified the root cause of this issue today, and it seems to be closely related to a similar issue I addressed in this PR, which fixes a bug with toasts. Given that this involves understanding how Vaul Drawer is designed and integrated into Dub, it might not be the most straightforward task for someone unfamiliar with the system.

@steven-tey, if you'd like, I’d be happy to take this on and submit a PR with both a potential solution and an alternative approach, along with my analysis.

steven-tey commented 1 week ago

Sure thing, go for it @unrenamed 🙏