search

dubstar-04 / FeedsAndSpeeds

FreeCAD Feed and Speeds Calculator
GNU Lesser General Public License v2.1
30 stars 8 forks source link

units & minor output panel changes #12

Open spanner888 opened 3 years ago

spanner888 commented 3 years ago

In addition to below - just noticed if you select a different TC in the drop down, that units reverts to metric...too tired to look any further tonight.

I have drafted out some minor changes, but am not sure how to send to you as the changes I have based on your pull request "[Draft] update form layout and use tool controllers", not on your latest master.

Changes are in PathFeedsAndSpeedsGui.py & PathFeedsAndSpeedsGui.ui

Your advice on how to proceed would be appreciated.

Changes are all in the Output pane: Converted output to whatever units user has set in preferences. Initial part of code for this needs to be moved to somewhere such as one of the class init's, but I am not sure which is best, so let you look that over. Couple of lines really debug as well & can be removed.

Did not change any of the inputs, as they mostly already auto switch to match user preferences.

Only issue with doing this is the surface speed is still in metric, regardless of user units preferences. I looked around but have not found what trigegrs the other input boxes to be unit aware.

Moved Spindle Speed to top of list to match calculation order and thus reduce user confusion, as Spindle Speed is calculated first, then it is used to calc hFeed then hFeed used to calc Power.

Added a hor line seperator between TC outputs & Power, to give user indication that power does not update/change in TC.
...Well added 3, but cannot see any of them, even after lotsa www searches, so added & disable a Single line text box to use as a spacer/label.
At least you can sorta see what I was trying to do. I always battle with QTdesigner.
noahwilliamsson commented 3 years ago

Just for the sake of discussion, I took some screenshots before and after.

I noticed that the units changed from mm/minute to mm/second with your PR. My FreeCAD installation was configured to use "Standard" units (Preferences > General > Units > Unit system) out of the box. To get back mm/minute I had to change change the units to "Metric small parts & CNC (mm, mm/min)".

Maybe it's a difference discussion but I'd like to see units for chipload (amount of material to be removed by each tooth), surface speed and spindle speed too.

The lineEdit disabled input box (Additional information:-) doesn't seem to be referenced anywhere in the code. Is it needed?

before after after-mm-per-min