duckdb / dbt-duckdb

dbt (http://getdbt.com) adapter for DuckDB (http://duckdb.org)
Apache License 2.0
935 stars 89 forks source link

Prep for 1.8.2 release #418

Closed guenp closed 4 months ago

guenp commented 4 months ago

dbt-core is on 1.8.4 and other adapters are all still using 1.8.x or below versioning. However, since the recent refactor, dbt adapters no longer require staying in pace with dbt versioning. From dbt team:

We generally recommend that major version bumps reflect major changes to the adapter and should therefore be reserved. Minor versions should reflect meaningful changes to behavior.

This release includes a major version bump for DuckDB from 0.10.x to 1.0.0 and support for the new DuckDB Secrets Manager, which could be categorized as a "meaningful changes" to the behavior (the feature gap between 0.10.x and 1.0.0 isn't huge - it was mostly bugfixes and stability improvements - and the secrets behavior is an addition that is backward compatible).

I started a discussion on dbt community Slack here: #adapter-ecosystem.

Update: Bumping major version based on discussion with dbt team Update: Sticking with minor version for now - once dbt-core 1.9 comes out, we're not sure if 1.8.x adapters will remain compatible, and bumping the version again will cause more confusion Update: OK, after a few more chats with the dbt adapters team and evaluating pros and cons, we decided to go with a minor release for now. Let it be so 🪄

jwills commented 4 months ago

Pro case: this is a major change (the secrets manager switchover and the DuckDB 1.0.0 constraint).

Con case: will be confusing to users, I'm not 100% confident that the dbt folks are actually going to maintain compat with 1.8.x adapters when they do dbt-core 1.9.0 and will we then need to do a dbt-duckdb 1.9.x that fixes the compatibility issues with dbt-core 1.9.x which will be extra-extra confusing

guenp commented 4 months ago

That makes sense. For now we can just keep the adapter major version synced with the with dbt-core major version, and after they go through the 1.9 update we can reevaluate. wdyt?

guenp commented 4 months ago

(I meant to just comment but fat fingered the wrong button)