duckdblabs / db-benchmark

reproducible benchmark of database-like ops
https://duckdblabs.github.io/db-benchmark/
Mozilla Public License 2.0
136 stars 27 forks source link

duckdb-latest fails #39

Closed quasiben closed 9 months ago

quasiben commented 9 months ago

When trying to setup duckdb-latest I get an error:

~/db-benchmark$ bash duckdb-latest/setup-duckdb-latest.sh
Downloading GitHub repo duckdb/duckdb@HEAD
Error: Failed to install 'duckdb' from GitHub:
  Does not appear to be an R package (no DESCRIPTION)
Execution halted

The docs page recommends doing the following:

install.packages('duckdb', repos=c('https://duckdb.r-universe.dev', 'https://cloud.r-project.org'))

I'm probably doing something wrong as I'm not very familiar with R

jangorecki commented 9 months ago

Try run commands from the script one by one a see which one fails. According to best practices packages should be installed from tar.gz file rather than a directory, as it is now in the script.

quasiben commented 9 months ago

Thanks for the quick response @jangorecki .

The Rscript install line fails:

$/db-benchmark$ Rscript -e 'install.packages("DBI", lib="./duckdb-latest/r-duckdb-latest")'
Error in contrib.url(repos, type) :
  trying to use CRAN without setting a mirror
Calls: install.packages -> startsWith -> contrib.url
Execution halted
jangorecki commented 9 months ago

Add repos="https://cloud.r-project.org" to install.packages call

quasiben commented 9 months ago

Thanks! That's moving things along nicely now. If it succeeds should I file a PR to update the script ?

jangorecki commented 9 months ago

user, or an org, may have local cran mirror, then hardcoding those may not be ideal, but most commonly it won't be a problem anyway, so I would say go ahead

Tmonster commented 9 months ago

Hi @quasiben are you still experiencing this issue or can I close it?

quasiben commented 9 months ago

Yup yup, thanks for closing and thank you to @jangorecki for helping me resolve the issue