removed browser integration prompt - Githubissues

duckduckgo / android-search-and-stories

DuckDuckGo Search & Stories for Android

https://duckduckgo.com/app

Other

425 stars 172 forks source link

removed browser integration prompt #308

Closed brindy closed 7 years ago

brindy commented 7 years ago

Reviewer: @subsymbolic Asana: https://app.asana.com/0/19626896268257/404579766834639/f CC:

Description:

Removes the prompts to integrate with Chrome and Firefox and the feed header. Also removed a fair amount of other "unused" code.

Steps to test this PR:

Launch the app. You should immediately see the feed with no integration prompt popup or dismissible panel at the top of the feed.

Reviewer Checklist:

[x] Ensure the PR solves the problem
[x] Review every line of code
[x] Ensure the PR does no harm by testing the changes thoroughly
[x] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR DRI Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications (Database connections, Grafana stats, CPU)