search

duckduckgo / p5-app-duckpan

DuckDuckHack OpenSource Development Application
http://metacpan.org/module/App::DuckPAN
Other
54 stars 47 forks source link

Create HTTP::Headers obj from headers hash #385

Closed moollaza closed 7 years ago

moollaza commented 7 years ago

Background

We've added support for Spices to use multiple headers, instead of just the accept_header.

The changes to DuckDuckGo are awaiting merge here: https://github.com/duckduckgo/duckduckgo/pull/208

The only remaining Spice, using the accept_header property has been updated here: https://github.com/duckduckgo/zeroclickinfo-spice/pull/3056

Note: This requires a new Perl module: HTTP::Headers

Description

This PR updates DuckPAN to support passing along the $headers hash reference when creating the HTTP::Request object, by instantiating a HTTP::Headers object

Testing

This can be tested by installing the newest DDG build, and running the DuckPAN Server in the Spice repo. The Skyscanner and CocoaPods Spices have already been updated to use the new spice headers property.

/cc @jbarrett

moollaza commented 7 years ago

We've now merged + released the headers changes in the DDG lib. We can move forward with testing + releasing these changes 👍