ducktors / turborepo-remote-cache

Open source implementation of the Turborepo custom remote cache server.
https://ducktors.github.io/turborepo-remote-cache/
MIT License
1.06k stars 102 forks source link

fix: Use BODY_LIMIT when creating app #445

Closed jgoz closed 1 week ago

jgoz commented 1 month ago

In this PR:

The BODY_LIMIT env variable was being used in the content type parser, but not when creating the fastify app. This meant the practical body limit could not be raised past 50MB.

This PR uses the BODY_LIMIT var for both values.

Checklist:

jgoz commented 1 month ago

@matteovivona Does this change make sense?

jakeinflab commented 3 weeks ago

I agree with this change. We are running a very large project where our cache size exceeds 50MB, resulting in issues with loading the cache. Could you please review this change? @matteovivona @jgoz

matteovivona commented 1 week ago

@jgoz thank you for your PR! It makes sense. Could you also update the documentation with this new variable? I would really appreciate it!

matteovivona commented 1 week ago

@all-contributors please add @jgoz for code and doc

allcontributors[bot] commented 1 week ago

@matteovivona

I've put up a pull request to add @jgoz! :tada:

jgoz commented 1 week ago

@fox1t @matteovivona The docs already have this variable listed, it just wasn't being used in this spot.

matteovivona commented 1 week ago

:tada: This PR is included in version 2.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: