Made lombok a non-transitive dependency - Githubissues

duosecurity / duo_universal_java

Duo OIDC-based two-factor authentication for Java web applications

https://duo.com/docs/duoweb

Other

14 stars 21 forks source link

Made lombok a non-transitive dependency #27

Closed concurrent-recursion closed 1 month ago

concurrent-recursion commented 10 months ago

I made lombok a non-transitive dependency in the pom file

Description

I made lombok an optional dependency instead of a provided dependency, which prevents it from being a transitive dependency

Motivation and Context

This keeps the lombok functionality in the project, while removing the dependency from being pulled into downstream projects Fixes issue https://github.com/duosecurity/duo_universal_java/issues/26

See Maven Optional Dependencies Docs

How Has This Been Tested?

The maven project was compiled and tests completed successfully.

Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

AaronAtDuo commented 1 month ago

We just got rid of Lombok