search

dupondje / PHP-Push-2

Z-Push Fork With CalDAV/LDAP Support
GNU Affero General Public License v3.0
67 stars 24 forks source link

Upgrade to Z-Push 2.1 #89

Open nafets227 opened 10 years ago

nafets227 commented 10 years ago

Upgrde to Z-Push 2.1 that is newly available. It will Need at least a Directory renaming in backend.

nafets227 commented 10 years ago

Hi all,

while looking to Z-Push 2.1 with modified Directory structure (one for each backend, and an own config.php for each backend) and remembering the discussion with dupondje that he does not like to modified Z-Push sources here, I think about removing the Z-Push "core" of this repository.

This would make users more flexible in combining Z-Push Versions with PHP-Push Versions, as Long as the Interfaces do not Change.

Let me know how you think about it.

dupondje commented 10 years ago

So you mean that we should only supply our backends (caldav/carddav) and let the users get the original z-push sources? Seems like a good idea, then we don't need to merge Z-Push changes anymore. The only bad thing is that we can't do ANY change anymore to Z-Push code. If there MUST be something patched to get PHP-Push working, then we need to supply a patch or something to z-push for our users, which makes it a bit more complicated.

nafets227 commented 10 years ago

Am 13.10.2013 22:21, schrieb dupondje:

So you mean that we should only supply our backends (caldav/carddav) and let the users get the original z-push sources? Seems like a good idea, then we don't need to merge Z-Push changes anymore. The only bad thing is that we can't do ANY change anymore to Z-Push code. If there MUST be something patched to get PHP-Push working, then we need to supply a patch or something to z-push for our users, which makes it a bit more complicated.

— Reply to this email directly or view it on GitHub https://github.com/dupondje/PHP-Push-2/issues/89#issuecomment-26226093.

Yes, thats my thinking, too. we get rid of the merging but loose the flexibility to patch Z-Push for us, if needed. Indeed, we could add single files we need to patch to our repo but then we are again in the Z-Push merging game, but with just the file(s) modified by us.

I think, if modifying Z-Push is necessary we could go the way described above and in parallel submit the change to the Z-Pusz team. After they accepted the patch we supplied and up from next Z-Push version we could again remove the file from our repo.

At least we would exactly know which files we modified...

So if you agree I would try to upgrade to Z-Push 2.1 that way. But before I try to support merging the two carddavs together (issue #83)

t3chguy commented 9 years ago

I've created a new port of Z-Push, with the base of 2.2Final, got both CardDAV Classes and the CardDAV Class working. Will be providing some support as soon as I create the repo on my Github.

fmbiete commented 9 years ago

@t3chguy maybe you are interested in this: https://github.com/fmbiete/Z-Push-contrib

It includes dupondje backends (CalDAV and ldap) and also CardDAV and IMAP.

t3chguy commented 9 years ago

@fmbiete I am having a slight issue, maybe you know of it, all my e-mails sent from EAS Devices. The Return Path is getting set to www-data@myFQDN.co.uk instead of the IMAP SASL Username, any ideas? Is this changed in the link you posted? Is this a thing that happens a lot? is there a way to fix it, anything? (www-data being the user that I have PHP-Push-2 running on)

fmbiete commented 9 years ago

In the dupondje and upstream version that problem was solved installing postfix in the server (and removing exim).

In Z-Push-contrib there are 3 methods to send mails: mail (the old method), sendmail and smtp. Also you can define the FROM, using date stored in ldap or SQL IMO the best method is smtp.