search

durableOne / orgmunge

MIT License
75 stars 4 forks source link

Added test to reproduce bug where ROOT is added when combining two documents. #14

Closed crdoconnor closed 10 months ago

crdoconnor commented 11 months ago

Hi, I've added a minimal case for a bug I ran across yesterday.

durableOne commented 10 months ago

Sorry for the delay. I was on vacation. I'll take a look

crdoconnor commented 10 months ago

No worries. I actually thought it might have been intentional so no problems if you want to reject it.

crdoconnor commented 10 months ago

*thought after submitting the test that is.

durableOne commented 10 months ago

Please see https://github.com/durableOne/orgmunge/commit/f8976cb128703dba80b73215fd364bf5bcd9cfd1 I have corrected the code of the test case that adds headings from 2 trees to show you the correct way of doing that. All tests now passing.

crdoconnor commented 10 months ago

ah awesome, thanks

On Sun, 21 Jan 2024, 21:42 Joe Riad, @.***> wrote:

Please see f8976cb https://github.com/durableOne/orgmunge/commit/f8976cb128703dba80b73215fd364bf5bcd9cfd1 I have corrected the code of the test case that adds headings from 2 trees to show you the correct way of doing that. All tests now passing.

— Reply to this email directly, view it on GitHub https://github.com/durableOne/orgmunge/pull/14#issuecomment-1902775542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOJKNMB243TDTCMF7DS64DYPWDVZAVCNFSM6AAAAABBCJ2LRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSG43TKNJUGI . You are receiving this because you authored the thread.Message ID: @.***>