Closed ruebot closed 9 years ago
@ruthtillman feel free to expand if you think I'm missing anything.
@ruebot, thanks! I was thinking something more along the lines of a stylesheet [1] that was included in the RDF [2] executed in the browser vs. pre-built. [1] https://github.com/fcrepo4/ontology/blob/master/owl2html.xsl [2] https://github.com/fcrepo4/ontology/blob/master/repository.rdf#L2
Thoughts?
Unless I'm not understanding things right, https://github.com/fcrepo4/ontology/blob/master/repository.rdf#L2 is owl, and PCDM is rdfs. That's why is just tweaked the existing rdfs2html.xsl
.
...oh. I see what you mean now, I think. You mean converting it on the fly?
That is exactly what I mean. Precisely! Just what I mean.
I would like to see "owl:priorVersion" in the actual PCDM ontology documents, ala this, and a corresponding exposure in the HTML view, ala this. But I think this PR, as is, is a very nice improvement. @ruebot, would you be willing to squash these 4 commits prior to another formal review and commit? :+1:
(I know I offered to take a look @ruebot, but it looks really tight from here and I can't even see a way to condense it further. Unsurprising, really.)
@awoods squashed!
@ruthtillman cool.
:+1: I think this is ready to ship. We need two more votes.
:+1:
@scossu @azaroth42, thoughts?
We need one more vote: @scossu? @azaroth42?
@scossu? @azaroth42? If you have concerns about this PR, please pass them along. Otherwise, let's get this into master
.
:+1: (Sorry for delays)
From my very basic familiarity with XSLT, it looks :+1:
…ss #23.