duraspace / pcdm

Portland Common Data Model
http://pcdm.org/models
Apache License 2.0
90 stars 9 forks source link

Adding optional buffer FileSet class and related predicates #68

Closed escowles closed 8 years ago

escowles commented 8 years ago

Objects can either link directly to Files, or link to FileSets that link to Files:

See also #69

awoods commented 8 years ago

:+1: pending update to: https://github.com/duraspace/pcdm/blob/27a133e2f5cdbf23cf0b2c125b2eb7f086c418bb/models.rdf#L15

tpendragon commented 8 years ago

I like this, but I do wonder (slightly) about the semantics of the fileset being the thing with the file, since there's no transitivity here.

escowles commented 8 years ago

@tpendragon Since FileSet is a subclass of Object, it's just another layer of Objects with a File. So if your app doesn't care about FileSets, then it can just treat it as an Object.

tpendragon commented 8 years ago

Oh! I'm not sure FileSet in this proposal should be an object. Doesn't this open up FileSets having FileSets?

cmharlow commented 8 years ago

Yes, and doesn't help avoiding conflation of what metadata goes on Object (work, RWO) and Fileset. But in this change having Fileset be a subclass of Object means you don't need to create a new 'manages' property.

azaroth42 commented 8 years ago

Collections could hasMember FileSets if they're subClassOf Object. That seems ... wrong. From meh to :-1: given this.

escowles commented 8 years ago

I agree with the concerns raised here about FileSets being subclasses of Object causing problems. Closing this issue in favor of #69, where we can continue to discuss what the relationships should look like and what metadata goes where.