search

duskload / react-device-detect

Detect device, and render view according to detected device type.
MIT License
2.82k stars 155 forks source link

Selectors for tablet device doesn't work on samsung tablet #197

Open ruchika-phalke opened 2 years ago

ruchika-phalke commented 2 years ago

Different selectors like isTablet, isMobile, isPortrait, isLandscape gives incorrect value. Device information :- Samsung Galaxy S7 Edge browser

hosembafer commented 9 months ago

Same for iPad Pro/Air

I did some research and discovered that there is a new class of "desktop class" browsers and they don't want to be categorized as tablets and identify themselves as desktop devices and it becomes very difficult to distinguish them.

To handle this, we can use navigator.maxTouchPointers as an additional criterion to detect tablets.

hosembafer commented 9 months ago

@duskload Hey, can you help here? I know it's a bit undefined situation with "desktop class" stuff, but maybe you can group all the related issues and pin them on the Issues tab? And maybe you have some thoughts about this?

tattegrainDrey commented 3 months ago

Same for iPad Pro/Air

I did some research and discovered that there is a new class of "desktop class" browsers and they don't want to be categorized as tablets and identify themselves as desktop devices and it becomes very difficult to distinguish them.

To handle this, we can use navigator.maxTouchPointers as an additional criterion to detect tablets.

That would work, but for me, my tablet and my phone give the same maxTouchPointers so it ends up being the same problem than isTablet not working