search

duskload / react-device-detect

Detect device, and render view according to detected device type.
MIT License
2.82k stars 155 forks source link

Chromium OS/Chrome OS is missing from OS map list #209

Open sharoncraddock opened 1 year ago

sharoncraddock commented 1 year ago
  1. I'd like to be able to detect Chromebook users - web says the OS is called Chrome OS, but using/inspecting your deviceDetect method I get "'Chromium OS" for the osName:
deviceDetect object {"isBrowser":true,"browserMajorVersion":"108","browserFullVersion":"108.0.0.0","browserName":"Chrome","engineName":"Blink","engineVersion":"108.0.0.0","osName":"Chromium OS","osVersion":"15183.78.0","userAgent":"Mozilla/5.0 (X11; CrOS x86_64 15183.78.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/[108.0.0.0](http://108.0.0.0/) Safari/537.36"}

  1. Add Chromium OS (and/or Chrome OS) to the list of OS types in https://github.com/duskload/react-device-detect/blob/master/src/constants/typesMaps.js

  2. I'd like to have the osName method return 'Chromium OS' when the OS is Chromium OS.