search

duvholt / i3-pager

Plasmoid pager for integrating i3 with KDE Plasma
GNU General Public License v3.0
37 stars 14 forks source link

Port to Plasma 6 (closes #30) #31

Closed collinmay closed 7 months ago

collinmay commented 8 months ago

These are low-quality changes. I have never used QT before and don't understand or claim to understand it. What I did to the CMakeLists.txt file is probably semantic garbage, but this is working for me.

collinmay commented 8 months ago

Unsure what was causing the issues I was having earlier with the Qt5 QDebug header getting picked up, but it's not happening to me anymore. Force-pushed an amended commit without the QDebug removal.

Thaodan commented 7 months ago

I have two PR's that should be merged before I think: https://github.com/duvholt/i3-pager/pull/28 https://github.com/duvholt/i3-pager/pull/27

JordanTwynham commented 7 months ago

Any reason this fix hasn't been merged yet?

Thaodan commented 7 months ago

Any reason this fix hasn't been merged yet?

It's not 100% functional could be on reason.

Also see my comments.

duvholt commented 7 months ago

Hi, sorry for not looking at this earlier. I did a review of #32 since that seemed like a more complete PR, but I want to say thanks for taking a look at Plasma 6 upgrade! It was especially useful for debugging why I couldn't get the other PR to build while this one worked with some small changes.

collinmay commented 7 months ago

Glad to see @Thaodan has done it right. Will be happy to see the other PR merged.