dwardor / plasma-applet-fanspeed-monitor

Plasma 5 Fan Speed Monitor Applet
GNU General Public License v2.0
8 stars 2 forks source link

Length of applet on small taskbars #3

Closed sammyspark closed 4 years ago

sammyspark commented 4 years ago

On smaller taskbars, the fanspeed gets cut off when the fan speed font size is at default size, as shown here. It would be really nice if instead of or in addition to the "Fan Speed Right Margin", we could have a "Fan Speed Applet Length" slider instead.

Also, if the sliders could have numbers or spin boxes to the right of them, that would be super awesome as well.

Thanks so much for the great applet and happy holidays!!

sammyspark commented 4 years ago

Oh also I've never worked with Plasma applets before but if you'd like, I can take a look at this myself in a couple days and try working on it. I don't wanna just take and not give back :sweat_smile:

dwardor commented 4 years ago

Could you give a screenshot to illustrate ? I must admit I've copy pasted the widget size code from thermal monitor and just adjusted widget width to height ratio (1.6 if I remember well but can be increased) as rpm speed is usually 7 characters vs 3 for temperature (everything gets auto adjusted as soon as you resize the widget... Does Thermal monitor have the same issue ?

sammyspark commented 4 years ago

I attached a screenshot and a link above, but in case the Markdown didn't render correctly, here they are in raw form:

Screenshot of issue: http://i.imgur.com/N2JkQ4O.png KDE Design tips for different types of sliders: https://hig.kde.org/components/editing/slider.html (this was in reference to how I would prefer to see the font size that is being displayed)

dwardor commented 4 years ago

edit .local/share/plasma/plasmoids/org.kde.fanspeedMonitor/contents/ui/main.qml

modify line 87 "itemWidth = itemHeight*1.6" replace 1.6 something bigger (I'd start with 2.0)

save

reboot

--> Tell me what works for you. Maybe we can introduce a parameter for this

Another solution is just to reduce Fan speed font size with slider ;-) !

dwardor commented 4 years ago

Just uploaded v1.1.0 try playing with the new parameter "Width to Height ratio" and the new sliders with numbers

sammyspark commented 4 years ago

Hey, just downloaded v1.1.0 from the Plasma store, the applet looks the same as before except for the settings menu. The slider for "Width to Height ratio" does not change anything. Additionally the slider glitches out because some of the values become very long due to floating point arithmetic.

dwardor commented 4 years ago

Did you click "apply" after adjusting Width to Height parameter ? (it only recomputes widget size once you click apply)

dwardor commented 4 years ago

Try new upload, the glitch due to floating point arithmetic is corrected Width to Height ratio has an effect here (after clicking apply) image image image

Wigdet width is measured from left of C of "CPU" to right of m of "rpm" and has changed between the first 2 screenshots from 1.2 to 1.6. Last step is eventual manual resizing with mouse of "Parent Frame" (see last screenshot)

dwardor commented 4 years ago

No news good news ? I'll be closing the issue then...