search

dwmkerr / terraform-aws-openshift

Create infrastructure with Terraform and AWS, install OpenShift. Party!
http://www.dwmkerr.com/get-up-and-running-with-openshift-on-aws
MIT License
170 stars 174 forks source link

Use the requirements.txt instead of hardcoding the version of ansible? #69

Open zoobab opened 6 years ago

zoobab commented 6 years ago

In the following section of install-from-bastion.sh, you specify by hand which version of ansible to use, which is different by version of openshift-ansible:

# Get the OpenShift 3.10 installer.
pip install -I ansible==2.6.5
git clone -b release-3.10 https://github.com/openshift/openshift-ansible

# Get the OpenShift 3.9 installer.
# pip install -I ansible==2.4.3.0
# git clone -b release-3.9 https://github.com/openshift/openshift-ansible

# Get the OpenShift 3.7 installer.
# pip install -Iv ansible==2.4.1.0
# git clone -b release-3.7 https://github.com/openshift/openshift-ansible

# Get the OpenShift 3.6 installer.
# pip install -Iv ansible==2.3.0.0
# git clone -b release-3.6 https://github.com/openshift/openshift-ansible

Would not it be better to use at least the requirements.txt shipped with openshift-ansible? And even further, in a venv.

dwmkerr commented 6 years ago

Agreed, sounds more sensible. I'll take a look into this once I look at 3.11.