search

dwyl / adoro

❤️ The little publishing tool you'll love using. [work-in-progress]
http://www.dwyl.io/
32 stars 8 forks source link

Which Markdown Parser? #24

Open nelsonic opened 8 years ago

nelsonic commented 8 years ago

We are currently using marked because it seemed like the better option at the time we were starting this project ... But Mr. @alanshaw has opted for _remarkable_ in his project: https://github.com/alanshaw/markdown-pdf

Which one should we be using and why? What makes one "better" than the other? are there more options to consider or are these the two best ones...?

If anyone has time to do empirical research on this topic it would be incredibly useful! :+1:

alanshaw commented 8 years ago

I swapped because for a long time marked was vulnerable and appeared abandoned.

https://david-dm.org/dwyl/adoro

nelsonic commented 8 years ago
adoro--security-vulnerabilities-in-dependencies

Wow... that's a lot of RED ink _pixels_... Ok. for now, we're switching to _remarkable_ and we can always re-visit this issue if anyone spots a performance, security or features issue with using it.

Thanks @alanshaw :+1:

des-des commented 8 years ago

If we are trying to create amp HTML compliant pages (see issue #33) should this be done during or after the md-html conversion? Our current approach is to use remarkable to build html from the markdown. Then, either using the custom rules in remarkable and/or through another conversion make the html amp compliment before inserting it into our template. Going to start down this route now, any thought appreciated!

nelsonic commented 8 years ago

@des-des as verbally discussed, your objective today should be to have a pipeline that converts MD > HMTL and then Check AMP Compliance Once you know what non-compliant html tags are generated by your Markdown Parser, you can write a transformer step from the HTML to AMP-HTML (TDD)