search

dwyl / hapi-auth-google

:lollipop: Let people authenticate with your application/website using their Google Account (OAuth2)
GNU General Public License v2.0
41 stars 6 forks source link

Hapi v17 compatibility #52

Closed Y-LyN-10 closed 7 years ago

Y-LyN-10 commented 7 years ago

I have no permission to push a new branch on dwyl/hapi-auth-google, so I am opening a pull request to the only one (existing branch) - master. I am sorry if that is not right, I will close it and open a new one if needed.

Regarding issue #51 , this is a Hapi v17 - Compatible version of hapi-auth-google plugin. Code reviews are highly welcome as I wish to improve this version (consider it as work in progress).

Any help is appreciated. Thank you!

PS. readme.md is not updated yet, but there is an example and tests

nelsonic commented 7 years ago

@Y-LyN-10 you should have permissions to write to the repo. image

Please confirm the command you are using to push to GitHub.

Y-LyN-10 commented 7 years ago

I found the mistake and created a new branch. Will create a pull request to that branch instead. I am sorry and thanks.