dwyl / hapi-socketio-redis-chat-example

:speech_balloon: Real-time Chat using Hapi.js + Socket.io + Redis Pub/Sub (example with tests!!)
GNU General Public License v2.0
364 stars 73 forks source link

Adds Elm front end example #91

Closed ZooeyMiller closed 7 years ago

ZooeyMiller commented 7 years ago

Adds an Elm front end to the hapi/socket.io/redis back end, with tests and instructions of how to run it locally to the README.md fixes #86

codecov[bot] commented 7 years ago

Codecov Report

Merging #91 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #91   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          52     52           
=====================================
  Hits           52     52
Impacted Files Coverage Δ
server.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 366236d...cbdba04. Read the comment docs.

nelsonic commented 7 years ago

Runs on localhost: image

Tests pass (as expected): image

However seeing debug (error) in console: image

Might be related to the fact that Redis is failing: image

https://stackoverflow.com/questions/39809595/redis-server-failure-when-server-starts image

ZooeyMiller commented 7 years ago

@nelsonic I just started redis-server, then ran npm start and didn't get any of the errors you have gotten, now that you've upgraded redis are you getting them? I have more or less no experience with redis so if this needs more in depth work to fix then could we pair or something?

nelsonic commented 7 years ago

@ZooeyMiller yeah, after upgrading Redis the app starts but .then soon after it throws an error: image

nelsonic commented 7 years ago

What I did next:

rm -rf node_modules
npm install
npm run start-elm

Appears to work ... image

However, still see the error in server console. image

This issue has been raised in: https://github.com/dwyl/hapi-error/issues/49

nelsonic commented 7 years ago

hapi-error@1.8.0 fixes this issue. https://github.com/dwyl/hapi-error/releases/tag/v1.8.0 trying it now on localhost.

nelsonic commented 7 years ago

No more errors on server. ✅ 😥