search

dwyl / learn-elm-architecture-in-javascript

:unicorn: Learn how to build web apps using the Elm Architecture in "vanilla" JavaScript (step-by-step TDD tutorial)!
https://todomvc-app.herokuapp.com
GNU General Public License v2.0
213 stars 19 forks source link

use of the word model/state #11

Closed sohilpandya closed 7 years ago

sohilpandya commented 7 years ago

Hi Nelson, Just wanted to raise a question on here.

Why call the argument in the update function model and then when calling the function have it defined as the state, could we just not call it model when calling it?

It is a minor thing but it may bamboozle a few beginner or am I being too cautious? what are your thoughts?

screen shot 2017-05-09 at 12 26 42
sohilpandya commented 7 years ago

Actually, halfway through this, I am unsure if this is even an issue. Just got a little too carried away. Will close and can be there for reference. 👍

nelsonic commented 7 years ago

@sohilpandya yeah, I think that is a 100% Valid/Legit Question! ❓ Why call it state in one place and model in the other? 🤔 This could easily be confusing to beginners... 😞

nelsonic commented 7 years ago

@sohilpandya I think I've replaced all instances of the word state in the code and docs. please take another look tomorrow and confirm it's clearererer. thanks! 👍

sohilpandya commented 7 years ago

Thanks @nelsonic! I'll definitely look into it. ❤️