dwyl / learn-elm-architecture-in-javascript

:unicorn: Learn how to build web apps using the Elm Architecture in "vanilla" JavaScript (step-by-step TDD tutorial)!
https://todomvc-app.herokuapp.com
GNU General Public License v2.0
213 stars 19 forks source link

Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28

Closed nelsonic closed 7 years ago

nelsonic commented 7 years ago

Fixes:

codecov[bot] commented 7 years ago

Codecov Report

Merging #28 into master will increase coverage by 4.65%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #28      +/-   ##
========================================
+ Coverage   95.34%   100%   +4.65%     
========================================
  Files           1      1              
  Lines          43     43              
========================================
+ Hits           41     43       +2     
+ Misses          2      0       -2
Impacted Files Coverage Ξ”
examples/counter-reset/counter.js 100% <0%> (+4.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update cc2f553...f4e81bf. Read the comment docs.

nelsonic commented 7 years ago

I know I'm a "freak" but the "95% Coverage" Was Bugging me!! image

image https://youtu.be/btO3kE2RrEY

@iteles please review/merge when you can. thanks!

nelsonic commented 7 years ago

@iteles review/merge not "urgent". but would be nice to get the "Tweet" done on Monday. πŸ˜‰

iteles commented 7 years ago

I love how you hearted the codecov comment here πŸ˜†