dwyl / learn-elm-architecture-in-javascript

:unicorn: Learn how to build web apps using the Elm Architecture in "vanilla" JavaScript (step-by-step TDD tutorial)!
https://todomvc-app.herokuapp.com
GNU General Public License v2.0
213 stars 19 forks source link

Multiple counters issue#40 #41

Closed nelsonic closed 6 years ago

nelsonic commented 6 years ago

Working on adding Multiple Counters with tests for #40 ... will assign when ready for review. πŸ‘

codecov[bot] commented 6 years ago

Codecov Report

Merging #41 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #41   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          43     44    +1     
=====================================
+ Hits           43     44    +1
Impacted Files Coverage Ξ”
examples/counter-reset/counter.js 100% <100%> (ΓΈ) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 145202f...7d6871e. Read the comment docs.

w0rm commented 6 years ago

@nelsonic I’m not the author of this illustration, please provide correct credits. https://twitter.com/01k/status/986528602635358208?s=20

nelsonic commented 6 years ago

@w0rm thank you for taking time to comment, πŸŽ‰ I have added the (CC BY 4.0) attribution below the image. βœ… Fantastic drawing BTW! ❀️ and great work on the Game tutorial: https://github.com/w0rm/creating-a-fun-game-with-elm πŸ‘Ύ and presentation: https://unsoundscapes.com/slides/2016-10-13-creating-a-fun-game-with-elm πŸ’Ž

w0rm commented 6 years ago

@nelsonic thanks for correcting the attribution. All the credits should really go to Kolja.