dwyl / learn-nightwatch

:last_quarter_moon_with_face: Learn how to use Nightwatch.js to easily & automatically test your web apps in *real* web browsers.
584 stars 214 forks source link

Selenium / Chrome driver download enhancement #76

Closed germain-gg closed 6 years ago

germain-gg commented 6 years ago

Hi,

I believe I found a better way to get both selenium and webdrivers.

Those two packages bring the binaries and expose a path to it. We end up with a nightwatch config looking like the following:

const seleniumServer = require("selenium-server");
const chromedriver = require("chromedriver");

module.exports = {
  // ...
  selenium: {
    "server_path" : seleniumServer.path,
    "cli_args" : {
      "webdriver.chrome.driver" : chromedriver.path
    }
  },
  // ...
};

I believe this simplifies the installation process. I'm willing to open a PR to do the changes. Just wanted to run that by you first

nelsonic commented 6 years ago

@gsouquet great find and thank you for opening this issue to inform/discuss! Yes, please do open a PR with this proposed change. thanks! 👍

nelsonic commented 6 years ago

@gsouquet given that your PR has been merged I'm closing this issue. feel free to re-open if you feel it has not been addressed. 👍